From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: Re: [pve-devel] [PATCH container 2/2] tests: add minimal test for LXC_NAME hosts entry
Date: Wed, 14 Jun 2023 13:32:37 +0200 [thread overview]
Message-ID: <f277d62a-da0c-95a9-a44f-b87f9305914d@proxmox.com> (raw)
In-Reply-To: <20230614104316.3250821-3-s.ivanov@proxmox.com>
Am 14/06/2023 um 12:43 schrieb Stoiko Ivanov:
> +++ b/src/test/test-alpine-003/etc/hosts
> @@ -0,0 +1,5 @@
> +127.0.0.1 localhost localhost.localdomain
> +::1 localhost localhost.localdomain
Misses the "LXC_NAME" line we want to test that it gets removed?
> +# --- BEGIN PVE ---
> +127.0.1.1 test3.proxmox.com test3
> +# --- END PVE ---
> diff --git a/src/test/test-alpine-003/etc/hosts.exp b/src/test/test-alpine-003/etc/hosts.exp
> new file mode 100644
> index 0000000..1d122ce
> --- /dev/null
> +++ b/src/test/test-alpine-003/etc/hosts.exp
> @@ -0,0 +1,5 @@
> +127.0.0.1 localhost localhost.localdomain
> +::1 localhost localhost.localdomain
> +# --- BEGIN PVE ---
> +10.0.0.100 test3.proxmox.com test3
> +# --- END PVE ---
i.e. hosts.exp is identical with hosts?
prev parent reply other threads:[~2023-06-14 11:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 10:43 [pve-devel] [PATCH container 0/2] add test for LXC_NAME hosts entry and fix a minor glitch Stoiko Ivanov
2023-06-14 10:43 ` [pve-devel] [PATCH container 1/2] tests: fix small syntax glitch Stoiko Ivanov
2023-06-14 10:43 ` [pve-devel] [PATCH container 2/2] tests: add minimal test for LXC_NAME hosts entry Stoiko Ivanov
2023-06-14 11:32 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f277d62a-da0c-95a9-a44f-b87f9305914d@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox