From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH widget-toolkit 1/1] inputpanel: improve validitychange check for advanced fields
Date: Sat, 11 Mar 2023 17:33:41 +0100 [thread overview]
Message-ID: <f2374aff-a073-d2c6-eaa9-9cc47baa4f43@proxmox.com> (raw)
In-Reply-To: <20230310140808.2245916-1-d.csapak@proxmox.com>
Am 10/03/2023 um 15:08 schrieb Dominik Csapak:
> instead of only checking the validity of the advanced items when
> the form validity changed as a whole, add a validitychange listener
> to each field in the advanced section.
>
> This improves the behaviour such that everytime an advanced field gets
> invalid the items are show, not only when the form was valid before.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> we need this for the next patch for manager to work correctly,
> but i guess this can happen on other panels too, just harder to trigger
>
> src/window/Edit.js | 27 ++++++++++++---------------
> 1 file changed, 12 insertions(+), 15 deletions(-)
>
>
applied, with Aaron's T-b, thanks!
prev parent reply other threads:[~2023-03-11 16:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 14:08 [pve-devel] " Dominik Csapak
2023-03-10 14:08 ` [pve-devel] [PATCH manager 1/1] ui: ceph: pool: don't always show advanced fields on create Dominik Csapak
2023-03-11 16:39 ` [pve-devel] applied: " Thomas Lamprecht
2023-03-10 14:45 ` [pve-devel] [PATCH widget-toolkit 1/1] inputpanel: improve validitychange check for advanced fields Aaron Lauterer
2023-03-11 16:33 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2374aff-a073-d2c6-eaa9-9cc47baa4f43@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox