From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Shan Shaji <s.shaji@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve_flutter_frontend v4] fix: ui: remove blue background under bottom bar in iOS
Date: Mon, 11 Aug 2025 14:22:36 +0200 [thread overview]
Message-ID: <f1c02564-0092-4594-b274-875365b58913@proxmox.com> (raw)
In-Reply-To: <20250804110634.64816-1-s.shaji@proxmox.com>
On 8/4/25 13:07, Shan Shaji wrote:
> In iOS, there was a blue background color visible beneath the bottom
> bar, which caused the app to not utilize the full screen height.
> Additionally, the colors of the app bar and the status bar
> differed when the user began scrolling.
>
> This issue was due to the container color used in the `ColoredSafeArea`
> widget, which wrapped the `SafeArea` widget. To fix the issue,
> remove the `ColoredSafeArea` and its usages, as all affected screens
> already include an `AppBar` widget. Therefore, using a separate
> `SafeArea` is not necessary.
>
> Additionaly since the `SafeArea` inside the resource tab and the
> task log page is removed as a result the filter sheet was interferring
> with the status bar in Android and notch in iOS. To fix the
> issue, wrap the drawer content in `SafeArea`.
>
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>
> note: Skips running the `dart format` command as there are formatting
> changes in the changed files and will be hard to identify the changes
> if the files are formatted.
>
> changes since v3:
> * Rebase with master.
>
> changes since v2:
> * Move dart format related commit message under "---"
> * Fix in-consistency of filter sheet on task log widget and
> resource tab. Both filter sheets are now rendered on top
> of App bar.
>
> changes since v1:
> * Rebase the changes with master.
>
> lib/pages/main_layout_slim.dart | 12 +++++++-----
> lib/widgets/colored_safe_area.dart | 18 ------------------
> lib/widgets/pve_console_menu_widget.dart | 3 +--
> lib/widgets/pve_lxc_options_widget.dart | 5 +----
> lib/widgets/pve_lxc_overview.dart | 5 +----
> lib/widgets/pve_node_overview.dart | 5 +----
> lib/widgets/pve_qemu_options_widget.dart | 5 +----
> lib/widgets/pve_qemu_overview.dart | 6 ++----
> lib/widgets/pve_task_log_widget.dart | 10 ++++------
> 9 files changed, 18 insertions(+), 51 deletions(-)
> delete mode 100644 lib/widgets/colored_safe_area.dart
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-08-11 12:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 11:06 [pve-devel] " Shan Shaji
2025-08-11 12:22 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1c02564-0092-4594-b274-875365b58913@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.shaji@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox