public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Roman Ondráček" <mail@romanondracek.cz>
To: "Max R. Carrara" <m.carrara@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH pve-storage v2 0/1] storage: add xz support
Date: Sun, 25 Oct 2026 15:34:43 +0100	[thread overview]
Message-ID: <f1ad370c86cda45cac39d05e7a24be1aa2dd5646.camel@romanondracek.cz> (raw)
In-Reply-To: <DH6PD6NSZS0U.3Q92IH3QXPH3J@proxmox.com>

[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]

On Thu Mar 19, 2026 at 11:56 AM CET, Max R. Carrara wrote:
> Thanks for your patches -- do you mind if I integrate them as part of
> another set of changes that I'm currently working on?
>
> Since I'm touching a lot of the surrounding code at the moment, it would
> need a lot of rebasing on either of our sides.
>
> You'd obviously still be accredited with adding support for xz in the
> form of an Originally-by trailer in the corresponding git commit
> messages.

Hi Max,

sorry for the very late reply, your mail slipped through the cracks on
my side.

Sure, an Originally-by trailer is perfectly fine with me.

As far as I can see, neither v1 nor v2 of your "Fix #2884: Implement
Subdirectory Scanning for Dir-Based Storage Types" series includes the
xz changes yet, so in the meantime I've sent a v3 rebased onto current
master, together with the pve-manager counterpart for the "Download
from URL" dialog:

https://lore.proxmox.com/pve-devel/20261025142720.1784119-1-mail@romanondracek.cz/

I've tested it on a VM with the current pvetest packages by downloading
the FreeBSD 15.0 bootonly ISO compressed with xz, both via the API and
via the dialog.

If it still conflicts with your series, feel free to fold it into
yours instead, whichever is easier for you.

Roman Ondráček

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      reply	other threads:[~2026-10-25 14:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-08 17:55 [PATCH pve-storage v2 0/1] storage: add xz support Roman Ondráček
2026-03-08 17:55 ` [PATCH pve-storage v2 1/1] " Roman Ondráček
2026-03-19 10:56 ` [PATCH pve-storage v2 0/1] " Max R. Carrara
2026-10-25 14:34   ` Roman Ondráček [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f1ad370c86cda45cac39d05e7a24be1aa2dd5646.camel@romanondracek.cz \
    --to=mail@romanondracek.cz \
    --cc=m.carrara@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal