From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Hanreich <s.hanreich@proxmox.com>
Subject: [pve-devel] applied: [PATCH proxmox-perl-rs 1/1] firewall: sdn: ignore EPERM when reading the legacy IPAM file
Date: Wed, 20 Nov 2024 16:25:40 +0100 [thread overview]
Message-ID: <f1749a36-ef21-482f-b04d-481cfbcdb2c0@proxmox.com> (raw)
In-Reply-To: <20241120144741.866590-1-s.hanreich@proxmox.com>
Am 20.11.24 um 15:47 schrieb Stefan Hanreich:
> On fresh installations, neither the new nor the old IPAM db file
> exist. This triggers our fallback code path and leads to errors in the
> syslog on fresh installs where there is no IPAM database. This happens
> whenever a firewall API call is made. Because of this, we choose to
> ignore EPERM when reading the legacy files. This is okay, because we
> move existing databases in the postinstall script of
> libpve-network-perl, making the situation where the new file does not
> exist, but the old file exists unlikely.
>
> Reported-by: Alexander Zeidler <a.zeidler@proxmox.com>
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
> The change from () to {} is due to rustfmt quirks. Adding the or made
> rustfmt change () to {()}, leading to another complaint by clippy
> about an unnecessary unit type in the closure, which I then removed.
I changed it a bit to be added as separate match arm, being explicit here
can be nice w.r.t. using git blame to find out why this is the way it is.
>
> pve-rs/src/firewall/sdn.rs | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-20 15:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 14:47 [pve-devel] " Stefan Hanreich
2024-11-20 15:25 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1749a36-ef21-482f-b04d-481cfbcdb2c0@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox