From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH guest-common] replication: snapshot cleanup: only attempt to remove snapshots that exist
Date: Thu, 18 Apr 2024 10:23:27 +0200 [thread overview]
Message-ID: <f1712f73-affc-475f-bb64-78cff2379141@proxmox.com> (raw)
In-Reply-To: <20240418070648.16462-1-f.ebner@proxmox.com>
Am 18/04/2024 um 09:06 schrieb Fiona Ebner:
> Since commit a6f5b35 ("replication: prepare: include volumes without
> snapshots in the result"), attempts would be made to remove previous
> replication snapshots from volumes on which they didn't exist. This
> was noticed by Thomas since the output of a replication test in
> pve-manager changed.
>
> The issue is not completely new, i.e. there was no check that the
> (previous) replication snapshot acutally exists before attempting
> removal during the cleanup phase. Fix the issue by adding such a
> check.
>
> The $replicate_snapshots hash is only used for this, so the change
> there is fine.
>
> Fixes: a6f5b35 ("replication: prepare: include volumes without snapshots in the result")
> Reported-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> src/PVE/Replication.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
applied both patches, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-04-18 8:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 7:06 [pve-devel] " Fiona Ebner
2024-04-18 7:06 ` [pve-devel] [PATCH manager] Revert "tests: update expected replication log output" Fiona Ebner
2024-04-18 8:23 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1712f73-affc-475f-bb64-78cff2379141@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox