From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH qemu-server] status: fix description of qmpstatus property
Date: Wed, 14 Jun 2023 13:16:20 +0200 [thread overview]
Message-ID: <f13ec183-eef1-93e4-cd42-2d98b91d9018@proxmox.com> (raw)
In-Reply-To: <20230303073503.7925-1-f.ebner@proxmox.com>
Ping
Am 03.03.23 um 08:35 schrieb Fiona Ebner:
> Using the word 'agent' is highly confusing here as there is no QMP
> agent and thus wrongly suggests that the value is related to the
> guest agent[0].
>
> [0]: https://forum.proxmox.com/threads/123590/post-537716
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> PVE/QemuServer.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 40be44db..0ded3ce3 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -2867,7 +2867,7 @@ our $vmstatus_return_properties = {
> optional => 1,
> },
> qmpstatus => {
> - description => "QEMU QMP agent status.",
> + description => "VM run state from the 'query-status' QMP monitor command.",
> type => 'string',
> optional => 1,
> },
next prev parent reply other threads:[~2023-06-14 11:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 7:35 Fiona Ebner
2023-06-14 11:16 ` Fiona Ebner [this message]
2023-06-14 11:34 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f13ec183-eef1-93e4-cd42-2d98b91d9018@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox