From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: Re: [pve-devel] [PATCH storage 2/3] disks: die if storage name is already in use
Date: Thu, 14 Jul 2022 14:30:08 +0200 [thread overview]
Message-ID: <f0bb6fe5-57b5-5e2d-3015-9a5c1fa4a4bf@proxmox.com> (raw)
In-Reply-To: <58a45815-0801-528b-dacb-aaaa920df722@proxmox.com>
On 7/14/22 14:12, Fabian Ebner wrote:
> Am 14.07.22 um 13:13 schrieb Dominik Csapak:> On 7/13/22 12:47, Aaron
> Lauterer wrote:
>>> + my $poollist = { map { $_->{name} => 1 } @{$pools} };
>>
>> does that really make sense here? would it not be easier to just
>> iterate? e.g.
>>
>> ----
>> for my $pool (@$pools) {
>> die "..." if $pool->{name} eq $name;
>> }
>> ----
>>
>> (i admit, it's 1 line longer, but a bit more readable?)
>>
>>> + die "pool '${name}' already exists on node '$node'\n" if
>
> Or just use grep ;)
>
even better :) (i always forget about perls grep)
next prev parent reply other threads:[~2022-07-14 12:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 10:47 [pve-devel] [PATCH storage 0/3] disks: add checks, allow add_storage on other nodes Aaron Lauterer
2022-07-13 10:47 ` [pve-devel] [PATCH storage 1/3] diskmanage: add mounted_paths Aaron Lauterer
2022-07-14 11:13 ` Dominik Csapak
2022-07-14 11:37 ` Aaron Lauterer
2022-07-13 10:47 ` [pve-devel] [PATCH storage 2/3] disks: die if storage name is already in use Aaron Lauterer
2022-07-14 11:13 ` Dominik Csapak
2022-07-14 12:12 ` Fabian Ebner
2022-07-14 12:30 ` Dominik Csapak [this message]
2022-07-13 10:47 ` [pve-devel] [PATCH storage 3/3] disks: allow add_storage for already configured local storage Aaron Lauterer
2022-07-14 11:23 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0bb6fe5-57b5-5e2d-3015-9a5c1fa4a4bf@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox