Re: [pve-devel] [PATCH v5 manager 2/3] ui: utils: add method to get VM data from resource store

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 15.02.21 16:26, Aaron Lauterer wrote:
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> v3 -> v4i -> v5: rebased
> v2 -> v3: nothing changed
> v1 -> v2: fixed linter errors
> 
> 
>  www/manager6/Utils.js | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
> index 7a1a7fb6..a298aac0 100644
> --- a/www/manager6/Utils.js
> +++ b/www/manager6/Utils.js
> @@ -1833,4 +1833,17 @@ Ext.define('PVE.Utils', {
>  	});
>      },
>  
> +    getNodeVMs: function(nodename) {
> +	let rstore = PVE.data.ResourceStore;
> +	let vms = {};
> +	rstore.data.items.forEach((item) => {

we normally use 'rstore' for a remote store, so I dislike the use when talking about
the in-memory ResourceStore as it's confusing.

FIY: In JS arrow functions the parenthesis can be dropped if there's only on parameter

And it seems like what you actually want is a .filter

let guests = rstore.data.items.filter(item => item.id.startsWith('qemu/') && item.data.node === nodename);

Maybe future proof this and allow to add the type, as we want the feature this
is made for also for CTs.

The whole thing could be reduced a bit with combinators, like (untested):

// type can be 'qemu', 'lxc' or left-out (for both)
// returns an Object with `vmid => guest-data` entries
getNodeGuests: function(nodename, type) {
    return PVE.data.ResourceStore.data
        .items
        .filter(item => (type && item.id.startsWith(`${type}/`)) && item.data.node === nodename)
        .reduce((acc, item) => acc[item.data.vmid] = item.data, {});
}

> +	    if (!item.id.startsWith('qemu/')) { return; }
> +	    let vmdata = item.data;
> +	    if (vmdata.node !== nodename) { return; }

Please avoid squishing early return ifs to one line. If that would be actually required
(see above for a general shorter approach), then it'd be nicer to write it as:

if (!item.id.startsWith('qemu/') || item.data.node !== nodename) {
    return;
}

> +
> +	    vms[vmdata.vmid] = vmdata;
> +	});
> +	return vms;
> +    },
> +
>  });
>