public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH manager/docs v3] handle missed jobs better
Date: Fri, 17 Jun 2022 17:34:41 +0200	[thread overview]
Message-ID: <f062c581-67b9-875f-713a-ae69fbf7594f@proxmox.com> (raw)
In-Reply-To: <20220613132411.3736044-1-d.csapak@proxmox.com>

Am 13/06/2022 um 15:24 schrieb Dominik Csapak:
> by adding a config option 'repeat-missed' for jobs that repeats the jobs
> on pvescheduler start. new default is 0, which is reverse to current
> behaviour (but the more expected one)
> 
> also always skips "missed" jobs when changing from disabled to enabled,
> since that is not expected
> 
> changes from v2:
> * indendation/whitespaces fixes
> * line length/wording fixes
> * renamed updated_job_schedule to update_last_runtime

picking up R-b's (much thanks for doing that!) could be also seen as somewhat
noteworthy change IMO, but I could find it out by actually checking the patches
rather quickly, so def. no biggie (just mentioning it early now that we work more
and more with patch series that got mainly reviewed by someone else than the one
pushing it out).

> 
> changes from v1:
> * rename 'skip-missed' to 'repeat-missed' and reverse the default
> * always update timestamp on disabled -> enabled
> * put the checkbox in advanced items
> 
> pve-manager:
> 
> Dominik Csapak (3):
>   fix #4026: add 'repeat-missed' option for jobs
>   fix #4053: don't run vzdump jobs when they change from
>     disabled->enabled
>   ui: dc/Backup: add 'repeat-missed' checkbox
> 
>  PVE/API2/Backup.pm          | 37 ++++++++++++++++++++++++++++++++-----
>  PVE/Jobs.pm                 |  8 +++++++-
>  PVE/Jobs/Plugin.pm          |  7 +++++++
>  PVE/Jobs/VZDump.pm          |  1 +
>  PVE/Service/pvescheduler.pm |  6 +++++-
>  www/manager6/dc/Backup.js   | 13 ++++++++++++-
>  6 files changed, 64 insertions(+), 8 deletions(-)
> 
> pve-docs:
> 
> Dominik Csapak (1):
>   vzdump: add section about 'repeat-missed'
> 
>  vzdump.adoc | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

applied, thanks!




      parent reply	other threads:[~2022-06-17 15:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-13 13:24 [pve-devel] " Dominik Csapak
2022-06-13 13:24 ` [pve-devel] [PATCH manager v3 1/3] fix #4026: add 'repeat-missed' option for jobs Dominik Csapak
2022-06-13 13:24 ` [pve-devel] [PATCH manager v3 2/3] fix #4053: don't run vzdump jobs when they change from disabled->enabled Dominik Csapak
2022-06-13 13:24 ` [pve-devel] [PATCH manager v3 3/3] ui: dc/Backup: add 'repeat-missed' checkbox Dominik Csapak
2022-06-13 13:24 ` [pve-devel] [PATCH docs v3 1/1] vzdump: add section about 'repeat-missed' Dominik Csapak
2022-06-17 15:34 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f062c581-67b9-875f-713a-ae69fbf7594f@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal