public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>,
	pve-devel@lists.proxmox.com
Subject: Re: [PATCH http-server 2/2] websocket: include close reason in debug log
Date: Wed, 9 Sep 2026 14:36:27 +0200	[thread overview]
Message-ID: <f030591c-0ba8-412e-8ce9-f7dec42bab4e@proxmox.com> (raw)
In-Reply-To: <20260909120309.432116-2-f.gruenbichler@proxmox.com>

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>

On 9/9/26 2:03 PM, Fabian Grünbichler wrote:
> if given by the client.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
>   src/PVE/APIServer/AnyEvent.pm | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/PVE/APIServer/AnyEvent.pm b/src/PVE/APIServer/AnyEvent.pm
> index 12701aa..44e4568 100644
> --- a/src/PVE/APIServer/AnyEvent.pm
> +++ b/src/PVE/APIServer/AnyEvent.pm
> @@ -678,7 +678,9 @@ sub websocket_proxy {
>                               $self->dprint("websocket received close with too short payload: $payload_len");
>                           } else {
>                               my $statuscode = unpack("n", $payload);
> -                            $self->dprint("websocket received close. status code: '$statuscode'");
> +                            my $reason = substr($payload, 2, $payload_len - 2);
> +                            $reason = '-' if !$reason;
> +                            $self->dprint("websocket received close. status code: '$statuscode', reason: '$reason'");
>                           }
>                           if (my $proxyhdl = $reqstate->{proxyhdl}) {
>                               $proxyhdl->{block_disconnect} = 1 if length $proxyhdl->{wbuf};





  reply	other threads:[~2026-09-09 12:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-09 12:03 [PATCH http-server 1/2] fix #8021: websocket: check length of close payload Fabian Grünbichler
2026-09-09 12:03 ` [PATCH http-server 2/2] websocket: include close reason in debug log Fabian Grünbichler
2026-09-09 12:36   ` Dominik Csapak [this message]
2026-09-09 12:34 ` [PATCH http-server 1/2] fix #8021: websocket: check length of close payload Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f030591c-0ba8-412e-8ce9-f7dec42bab4e@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal