public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [RFC PATCH manager 3/3] ui: enable multiColumnSort for storage backup content
Date: Sat, 22 Apr 2023 09:21:36 +0200	[thread overview]
Message-ID: <f02319ef-4b8d-7860-76db-be0a29ca45d2@proxmox.com> (raw)
In-Reply-To: <20230420080616.836255-3-d.csapak@proxmox.com>

On 20/04/2023 10:06, Dominik Csapak wrote:
> this enables the user to sort the grid by multiple columns
> simultaneously, e.g. by vmid and then by date
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> sending as rfc because i'm not so sure about this.
> 
> on one hand, this allows to recreate the original sorting if users want
> that, but the selection is a bit weird. there is no way to 'unsort'

the original sorting was strange and confusing, while it would be
at least not as confusing with the columns shown it's IMO just not
a good fit for a simple grid.

If we want to make this better, we should adopt a tree view, Fiona
even made a patch for that IIRC, either when she reworked the content
view or when adding group pruning in Proxmox VE (we definitively
talked about doing that off list, the patch might be imagination —
didn't check). Albeit tree views and sorting are naturally not the
greatest thing, an configurable "group by VMID" checkbox could be the
most flexible variant (meaning most edge cases and probabky code too..)

> columns again, it simply uses the last 3 columns that were clicked
> 
> especially with the last patch (statefulness) it becomes weird, but
> maybe we want this more than we want it to be stateful?

tbh. I want neither ;-) At least the chosen full-grid stateful way,
see reply to respective patch.




  parent reply	other threads:[~2023-04-22  7:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-20  8:06 [pve-devel] [PATCH manager 1/3] fix #4678: ui: don't sort storage backup content by vmid by default Dominik Csapak
2023-04-20  8:06 ` [pve-devel] [PATCH manager 2/3] ui: make storage backup content stateful Dominik Csapak
2023-04-22  7:21   ` Thomas Lamprecht
2023-04-20  8:06 ` [pve-devel] [RFC PATCH manager 3/3] ui: enable multiColumnSort for storage backup content Dominik Csapak
2023-04-20 13:39   ` Aaron Lauterer
2023-04-22  7:21   ` Thomas Lamprecht [this message]
2023-04-22  7:38 ` [pve-devel] [PATCH manager 1/3] fix #4678: ui: don't sort storage backup content by vmid by default Thomas Lamprecht
2023-04-22  7:52   ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f02319ef-4b8d-7860-76db-be0a29ca45d2@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal