Re: [pve-devel] [PATCH container v5 2/4] lxc: get volid through parse_volume()

From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
	"Daniel Kral" <d.kral@proxmox.com>,
	"Michael Köppl" <m.koeppl@proxmox.com>
Subject: Re: [pve-devel] [PATCH container v5 2/4] lxc: get volid through parse_volume()
Date: Wed, 14 May 2025 16:18:15 +0200	[thread overview]
Message-ID: <f020d2bc-83cc-4e42-aeeb-a6d0fe6ce2f3@proxmox.com> (raw)
In-Reply-To: <95f9bf53-52d9-4399-bec0-de2499719de0@proxmox.com>

Am 13.05.25 um 15:48 schrieb Daniel Kral:
> On 5/13/25 10:03, Michael Köppl wrote:
>> The value in $conf->{opt} is not necessarily a volume ID. To ensure that
>> a valid volume ID is used, it is retrieved by calling parse_volume().
>>
>> Co-authored-by: Stefan Hrdlicka
> 
> As already discussed in person, the email here is omitted because git 
> send-email seems to know about the Co-authored-by git trailer here and 
> wants to append it to the CC, but since the email doesn't exist anymore, 
> it doesn't work and will not go through with sending the email.

Should be resolved using git send-email's `--suppress-cc=all` option
when sending this patch(es), for details see:

https://git-scm.com/docs/git-send-email#Documentation/git-send-email.txt---suppress-ccltcategorygt

> 
> I wonder if it'd be more appropriate to use "Originally-by" here as it 
> still shows who worked on this originally and then the email could be 
> added because it doesn't try to send a copy to that email. But that's 
> just nit-picking, because I have not seen trailers without email 
> addresses yet.

Depends on the changes and always a bit of a gut-call for such things,
but would be also OK in this case.

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel