public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Daniel Koć" <daniel@xn--ko-wla.pl>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] Some translation strings missing
Date: Tue, 4 May 2021 13:44:14 +0200	[thread overview]
Message-ID: <f0080171-a108-3633-673c-6571f02e98a6@xn--ko-wla.pl> (raw)
In-Reply-To: <01e6faf2-cb15-d021-bf50-f5606ba1909d@proxmox.com>

W dniu 04.05.2021 o 09:12, Thomas Lamprecht pisze:
> Some of those are things like "OSD" or "Ceph" which cannot be translated, 


I don't see there is a strong dividing line. The only ones that really
should not be translated are those which would create technical
problems. Other than that there could be for example transliterations
(like "Цэпх" or "Цэф" for Ceph in cyryllic - just like McDonald's in
Russia or Bulgaria), aliases ("IP 4" instead of "IPv4") or maybe long
versions etc. One never knows.

On the other hand there are also some rare unneeded ones, like:

#: pve-manager/www/manager6/storage/Base.js:65
msgid "1"
msgstr ""

#: pve-manager/www/manager6/data/ResourceStore.js:186
msgid "maxcpu"
msgstr ""


> Do you want to take a shot at this and send a patch? It shouldn't be
> too hard,
> relatively speaking.

Yes, I will try that so we can move forward.

It would also help me send translation changes so they can be easily
applied.


> The latter was not made a gettext as it's a long text, really different
> from the other classic field or button label texts. It changed a few times
> already, and it's way harder to review for correctness. Further, we
> currently cannot detect gettext instances spanning over multiple lines, so
> the parser would need adaption.
> That's not saying I'd reject making it a gettext in general, just stating
> the reasoning for initially not doing so.

Sure, I understand that. Just some thoughts:

At some point it would be good to let translators catch up with the
latest changes before the release. I see no problem with rearranging
text like this, but it can be "freezed" for translation in RC phase and
"unfrozen" after the release. I was translating some rare big chunks of
gettext before, so it exists in the real world.


-- 
"Holy mother forking shirt balls!" [E. Shellstrop]




      reply	other threads:[~2021-05-04 12:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-04  5:57 Daniel Koć
2021-05-04  7:12 ` Thomas Lamprecht
2021-05-04 11:44   ` Daniel Koć [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f0080171-a108-3633-673c-6571f02e98a6@xn--ko-wla.pl \
    --to=daniel@xn--ko-wla.pl \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal