* [pve-devel] [PATCH container] fix #3635: fix pool permission checks on create
@ 2021-10-22 6:44 Dominik Csapak
2022-02-08 13:22 ` Mira Limbeck
2022-02-11 7:30 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 2 replies; 3+ messages in thread
From: Dominik Csapak @ 2021-10-22 6:44 UTC (permalink / raw)
To: pve-devel
we do not need Permissions.Modify on the pool, so remove it like
we did in
qemu-server 4fc5242 ("fix pool permission checks on create")
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/PVE/API2/LXC.pm | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index 69df366..0ae67a1 100644
--- a/src/PVE/API2/LXC.pm
+++ b/src/PVE/API2/LXC.pm
@@ -233,7 +233,6 @@ __PACKAGE__->register_method({
my $pool = extract_param($param, 'pool');
if (defined($pool)) {
$rpcenv->check_pool_exist($pool);
- $rpcenv->check_perm_modify($authuser, "/pool/$pool");
}
if ($rpcenv->check($authuser, "/vms/$vmid", ['VM.Allocate'], 1)) {
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [pve-devel] [PATCH container] fix #3635: fix pool permission checks on create
2021-10-22 6:44 [pve-devel] [PATCH container] fix #3635: fix pool permission checks on create Dominik Csapak
@ 2022-02-08 13:22 ` Mira Limbeck
2022-02-11 7:30 ` [pve-devel] applied: " Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Mira Limbeck @ 2022-02-08 13:22 UTC (permalink / raw)
To: pve-devel
On 10/22/21 08:44, Dominik Csapak wrote:
> we do not need Permissions.Modify on the pool, so remove it like
> we did in
>
> qemu-server 4fc5242 ("fix pool permission checks on create")
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/PVE/API2/LXC.pm | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
> index 69df366..0ae67a1 100644
> --- a/src/PVE/API2/LXC.pm
> +++ b/src/PVE/API2/LXC.pm
> @@ -233,7 +233,6 @@ __PACKAGE__->register_method({
> my $pool = extract_param($param, 'pool');
> if (defined($pool)) {
> $rpcenv->check_pool_exist($pool);
> - $rpcenv->check_perm_modify($authuser, "/pool/$pool");
> }
>
> if ($rpcenv->check($authuser, "/vms/$vmid", ['VM.Allocate'], 1)) {
Works when no Permissions.Modify and no Pool.Allocate permission is set.
So consider this:
Tested-by: Mira Limbeck <m.limbeck@proxmox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* [pve-devel] applied: [PATCH container] fix #3635: fix pool permission checks on create
2021-10-22 6:44 [pve-devel] [PATCH container] fix #3635: fix pool permission checks on create Dominik Csapak
2022-02-08 13:22 ` Mira Limbeck
@ 2022-02-11 7:30 ` Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2022-02-11 7:30 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak
On 22.10.21 08:44, Dominik Csapak wrote:
> we do not need Permissions.Modify on the pool, so remove it like
> we did in
>
> qemu-server 4fc5242 ("fix pool permission checks on create")
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/PVE/API2/LXC.pm | 1 -
> 1 file changed, 1 deletion(-)
>
>
applied, with Mira's T-b and slightly more context in the commit message, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-11 7:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-22 6:44 [pve-devel] [PATCH container] fix #3635: fix pool permission checks on create Dominik Csapak
2022-02-08 13:22 ` Mira Limbeck
2022-02-11 7:30 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox