From: Mira Limbeck <m.limbeck@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH container] fix #3635: fix pool permission checks on create
Date: Tue, 8 Feb 2022 14:22:13 +0100 [thread overview]
Message-ID: <efccbf06-8198-0a8e-32e8-81b998f108d6@proxmox.com> (raw)
In-Reply-To: <20211022064413.113127-1-d.csapak@proxmox.com>
On 10/22/21 08:44, Dominik Csapak wrote:
> we do not need Permissions.Modify on the pool, so remove it like
> we did in
>
> qemu-server 4fc5242 ("fix pool permission checks on create")
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/PVE/API2/LXC.pm | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
> index 69df366..0ae67a1 100644
> --- a/src/PVE/API2/LXC.pm
> +++ b/src/PVE/API2/LXC.pm
> @@ -233,7 +233,6 @@ __PACKAGE__->register_method({
> my $pool = extract_param($param, 'pool');
> if (defined($pool)) {
> $rpcenv->check_pool_exist($pool);
> - $rpcenv->check_perm_modify($authuser, "/pool/$pool");
> }
>
> if ($rpcenv->check($authuser, "/vms/$vmid", ['VM.Allocate'], 1)) {
Works when no Permissions.Modify and no Pool.Allocate permission is set.
So consider this:
Tested-by: Mira Limbeck <m.limbeck@proxmox.com>
next prev parent reply other threads:[~2022-02-08 13:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 6:44 Dominik Csapak
2022-02-08 13:22 ` Mira Limbeck [this message]
2022-02-11 7:30 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efccbf06-8198-0a8e-32e8-81b998f108d6@proxmox.com \
--to=m.limbeck@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox