From: Fabian Ebner <f.ebner@proxmox.com>
To: Matthias Heiserer <m.heiserer@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH v5 manager 0/4] BackupView as TreePanel
Date: Thu, 7 Apr 2022 12:37:46 +0200 [thread overview]
Message-ID: <ef5b06a4-83bf-3ff4-37c8-502fbe50435c@proxmox.com> (raw)
In-Reply-To: <20220407083439.2413546-1-m.heiserer@proxmox.com>
Am 07.04.22 um 10:34 schrieb Matthias Heiserer:
> Depends on https://lists.proxmox.com/pipermail/pve-devel/2022-March/052322.html
>
> I hope I didn't miss anything this time :)
>
> Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
Next time, please add the tag to the unchanged patches directly. I did
look at the changes to patch 2/4 now and everything looks fine to me, so
the tag /is/ also valid for the whole v5 ;)
prev parent reply other threads:[~2022-04-07 10:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 8:34 Matthias Heiserer
2022-04-07 8:34 ` [pve-devel] [PATCH v5 manager 1/4] ui: Utils: Helpers for backup type and icon Matthias Heiserer
2022-04-07 8:34 ` [pve-devel] [PATCH v5 manager 2/4] ui: storage: Rewrite backup content view as TreePanel Matthias Heiserer
2022-04-07 8:34 ` [pve-devel] [PATCH v5 manager 3/4] ui: delete BackupView and replace it with the new Tree BackupView Matthias Heiserer
2022-04-07 8:34 ` [pve-devel] [PATCH v5 manager 4/4] ui: content view: remove dead code Matthias Heiserer
2022-04-07 10:37 ` Fabian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef5b06a4-83bf-3ff4-37c8-502fbe50435c@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox