From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH qemu-server 1/2] tests: improve multiarch build support
Date: Tue, 3 Feb 2026 16:01:07 +0100 [thread overview]
Message-ID: <ee782cc6-5e62-4d56-91bc-e9fe57af2916@proxmox.com> (raw)
In-Reply-To: <20260203142209.3614946-1-d.csapak@proxmox.com>
Am 03.02.26 um 15:21 schrieb Dominik Csapak:
> The CPUConfig module sets the local 'host_arch' on loading, so instead
> to try to mock all subs that access this variable, provide a setter only
> intended for tests (and warn when using this).
Would be nicer to get a local get_host_arch that just return's the PVE::Tools'
method result, as we then could override the getter without having to worry
about this method being misused in the future by accident.
Moving the CPU model initialization into a sub, like suggested in my reply
to Fiona's patches, and redoing that on a simulated switch of the host
architecture would be also the slightly nicer interface IMO.
>
> Also, we have to override the 'get_host_arch' in the Helpers module too.
The helper module has no such method? There is only get_vm_arch there and
some usage of PVE::Tools' get_host_arch? Or is it because we import the one
from PVE::Tools there?
next prev parent reply other threads:[~2026-02-03 15:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 14:16 Dominik Csapak
2026-02-03 14:16 ` [PATCH qemu-server 2/2] tests: cfg2cmd: add some architecture tests Dominik Csapak
2026-02-03 15:01 ` Thomas Lamprecht [this message]
2026-02-03 15:04 ` [PATCH qemu-server 1/2] tests: improve multiarch build support Dominik Csapak
2026-02-03 15:09 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee782cc6-5e62-4d56-91bc-e9fe57af2916@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox