From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, d.tschlatscher@proxmox.com
Subject: Re: [pve-devel] [PATCH v3 container] fix: #3927: Error codes when starting/stopping
Date: Tue, 14 Jun 2022 12:46:52 +0200 [thread overview]
Message-ID: <ee6ff5f9-b8a7-a145-c839-ab8c548caeed@proxmox.com> (raw)
In-Reply-To: <20220321093305.3585964-1-d.tschlatscher@proxmox.com>
Am 21.03.22 um 10:33 schrieb Daniel Tschlatscher:
> containers Stopping and starting a container that is already in the desired
> state will not return an error value on the CLI anymore. The same as VMs do,
> when they are stopped but not running.
>
> Signed-off-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
This also applies to the second patch: I'd feel more comfortable keeping
the error exit codes for the start commands. There might be users
already relying upon this behavior. If start succeeds, we know we have a
freshly started instance. We actually rely on it a bit ourselves, for
migration to detect a bogus instance already running on the target node.
For the stop command, it's not as relevant IMHO, and I'm fine with
either way, but we might want to wait until the next major release as it
can be seen as a breaking API change too.
prev parent reply other threads:[~2022-06-14 10:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 9:33 Daniel Tschlatscher
2022-03-21 9:33 ` [pve-devel] [PATCH qemu-server] Starting a running VM does not return an error Daniel Tschlatscher
2022-06-14 10:46 ` Fabian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee6ff5f9-b8a7-a145-c839-ab8c548caeed@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=d.tschlatscher@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox