From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>,
Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 1/2] ceph: remove global pg bits setting
Date: Wed, 20 Sep 2023 15:21:14 +0200 [thread overview]
Message-ID: <ee5e4e70-e381-4f29-bbd0-1021f5f97f34@proxmox.com> (raw)
In-Reply-To: <398db91c-0244-4a0d-912a-73c77333939a@proxmox.com>
Am 20/09/2023 um 14:10 schrieb Dominik Csapak:
> sadly removing these parameters would be a breaking change
>
@maximiliano: how does ceph react if one sets this currently?
I.e., does it silently accepts unknown config keys, or does it break
something?
Because if it's the latter we can assume that nobody uses this
anyway and simply remove it in any release.
Otherwise, yes, dropping the usage but keeping the API parameter
with reducing the description to something like:
"depreacted, will be removed with Proxmox VE 9" would be slightly
better, not that I think it will make a difference in practice
(this is very niche stuff)..
next prev parent reply other threads:[~2023-09-20 13:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 9:49 Maximiliano Sandoval
2023-09-07 9:49 ` [pve-devel] [PATCH manager 2/2] ceph: api: use snake_case when setting options Maximiliano Sandoval
2023-09-20 12:10 ` [pve-devel] [PATCH manager 1/2] ceph: remove global pg bits setting Dominik Csapak
2023-09-20 13:21 ` Thomas Lamprecht [this message]
2023-09-20 13:42 ` Maximiliano Sandoval
2023-09-20 14:27 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee5e4e70-e381-4f29-bbd0-1021f5f97f34@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox