From: Fiona Ebner <f.ebner@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu 3/3] blockdev: query file child QMP command
Date: Mon, 30 Jun 2025 16:23:45 +0200 [thread overview]
Message-ID: <ee51d723-166d-407f-be0a-58c631113381@proxmox.com> (raw)
In-Reply-To: <1751287337.5ct5ta78ui.astroid@yuna.none>
Am 30.06.25 um 14:43 schrieb Fabian Grünbichler:
> On June 26, 2025 6:04 pm, Fiona Ebner wrote:
>> There currently does not seem to be a good way to obtain information
>> about the file child of a node, so add a custom command. The
>> query-block and query-named-block-nodes commands lack the necessary
>> info and while x-debug-query-block-graph exists, that is explicitly
>> only for debugging and experimental.
>>
>> This is requried for e.g. blockdev-mirror in PVE to determine the
>> node below the top throttle node.
>>
>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>> ---
>>
>> Alternatively, we could think about adding the node name of the file
>> child to the info returned by query-named-block-nodes. I can give that
>> a shot and also ask upstream which approach is prefered.
>
> that might be nice, or alternatively if we go with our custom solution
> here for now - give it a prefixed name to avoid potential clashes with a
> future upstream variant?
Since the variant mentioned here is much nicer for the
unplug-after-mirror scenario and seems quite natural, I'll go with that:
https://lore.kernel.org/qemu-devel/20250630141421.1558724-1-f.ebner@proxmox.com/
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-06-30 14:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 16:04 [pve-devel] [PATCH-SERIES qemu 0/3] prepartion for blockdev Fiona Ebner
2025-06-26 16:04 ` [pve-devel] [PATCH qemu 1/3] PVE backup: prepare for the switch to using blockdev rather than drive Fiona Ebner
2025-06-26 16:04 ` [pve-devel] [PATCH qemu 2/3] block/zeroinit: support using as blockdev driver Fiona Ebner
2025-06-26 16:04 ` [pve-devel] [PATCH qemu 3/3] blockdev: query file child QMP command Fiona Ebner
2025-06-30 12:43 ` Fabian Grünbichler
2025-06-30 14:23 ` Fiona Ebner [this message]
2025-06-27 15:51 ` [pve-devel] [PATCH qemu 4/4] block/alloc-track: support using as blockdev driver Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee51d723-166d-407f-be0a-58c631113381@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox