From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu] fix patch for accepting NULL qiov when padding
Date: Tue, 12 Mar 2024 13:14:48 +0100 [thread overview]
Message-ID: <ee3ffedd-0c37-439d-b9e6-b9210769e970@proxmox.com> (raw)
In-Reply-To: <20240312084750.57549-1-f.ebner@proxmox.com>
Am 12/03/2024 um 09:47 schrieb Fiona Ebner:
> All callers of the function pass an address, so dereferencing once
> before checking for NULL is required. It's also necessary to update
> bytes and offset nevertheless, so the request will actually be aligned
> later and not trigger an assertion failure.
>
> Seems like this was accidentally broken in 8dca018 ("udpate and rebase
> to QEMU v6.0.0") and this is effectively a revert to the original
> version of the patch. The qiov functions changed back then, which
> might've been the reason Stefan tried to simplify the patch.
>
> Should fix live-import for certain kinds of VMDK images.
>
> Reported-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> ...accept-NULL-qiov-in-bdrv_pad_request.patch | 59 ++++++++++++++-----
> 1 file changed, 45 insertions(+), 14 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2024-03-12 12:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 8:47 [pve-devel] " Fiona Ebner
2024-03-12 12:14 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee3ffedd-0c37-439d-b9e6-b9210769e970@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox