Re: [PATCH proxmox-ve-rs 8/9] ve-config: frr: implement frr config generation for route maps

[Hannes Laimer <h.laimer@proxmox.com>]

On 2026-03-25 10:42, Stefan Hanreich wrote:
> Implements conversion traits for all the section config types, so they
> can be converted into their respective FRR template counterpart.
> 
> This module contains a helper for adding all route map entries to an
> existing FRR configuration. It will overwrite existing route map
> entries that have the same name AND order number. But if entries with
> the same name, but different ordering, exist they will only be added
> to the existing FRR configuration without dropping the other route map
> entries.
> This currently not relevant either way, because the initial API
> implementation will reject creating route maps with names of route
> maps that the stack auto-generates. In the future this behavior can
> be used for selectively overriding / appending existing Proxmox VE
> route maps.
> 
> The helper also automatically orders route map entries according to
> their ordering number. This allows for deterministic FRR configuration
> output, which is important for tests and convenient for human
> readability.
> 
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---

[..]

> +    /// Add a list of Route Map Entries to a [`FrrConfig`].
> +    ///
> +    /// This method takes a list of Route Map Entries and adds them to given FRR configuration.
> +    /// Existing Route Map entries with the same name, but different ordering number will remain in
> +    /// the configuration. Entries with the same ordering will get merged.
> +    ///
> +    /// This behavior is different from Prefix Lists, where we overwrite existing Prefix Lists in
> +    /// the FRR configuration. The reason for this is that users can override the Route Map setting
> +    /// in the EVPN controller.
> +    pub fn build_frr_route_maps(
> +        config: impl IntoIterator<Item = RouteMap>,
> +        frr_config: &mut FrrConfig,
> +    ) -> Result<(), anyhow::Error> {
> +        for route_map in config.into_iter() {
> +            let RouteMap::RouteMapEntry(route_map) = route_map;
> +            let route_map_name = RouteMapName::new(route_map.id.route_map_id.to_string());
> +
> +            if let Some(frr_route_map) = frr_config.routemaps.get_mut(&route_map_name) {
> +                let idx =
> +                    frr_route_map.partition_point(|element| element.seq <= route_map.id().order());
> +                frr_route_map.insert(idx, route_map.into());

with this we would end up having multiple entries with the same seq, frr
doesn't care, just bringing it up cause the doc mentions merging

> +            } else {
> +                frr_config
> +                    .routemaps
> +                    .insert(route_map_name, vec![route_map.into()]);
> +            }
> +        }
> +
> +        Ok(())
> +    }

[..]