From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Daniel Kral <d.kral@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH installer 1/3] common: allow lowercase and uppercase zfs raid levels
Date: Wed, 20 Nov 2024 20:09:56 +0100 [thread overview]
Message-ID: <edd308e6-66e7-4a53-99aa-9428b8fdfda5@proxmox.com> (raw)
In-Reply-To: <20241120182414.125789-1-d.kral@proxmox.com>
Am 20.11.24 um 19:24 schrieb Daniel Kral:> Allows the ZFS RAID levels to be either lowercase or uppercase when
> deserializing them from string values, i.e. currently only the config
> value of `zfs.raid` in auto-installer answer files.
>
> This partly fixes a regression, where deserializing the `zfs.raid`
> property in answer files were only possible with uppercase values for
> the ZFS RAID Z-levels, opposed to only lowercase as in previous
> versions. This breaks the user API, as users cannot use the same answer
> files as before for ZFS RAID Z-levels (the prepare-iso command fails).
>
> Fixes: 510b0c008fb1 ("common: simplifying filesystem type serializing & Display trait impl")
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
> ---
> proxmox-installer-common/src/options.rs | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-20 19:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 18:24 [pve-devel] " Daniel Kral
2024-11-20 18:24 ` [pve-devel] [PATCH installer 2/3] common: allow lowercase and uppercase btrfs " Daniel Kral
2024-11-20 18:24 ` [pve-devel] [PATCH installer 3/3] common: make btrfs disk options uppercase for consistency Daniel Kral
2024-11-20 19:09 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edd308e6-66e7-4a53-99aa-9428b8fdfda5@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox