From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] ui: fix height 'extra cpu flags' field in create wizard
Date: Mon, 6 Nov 2023 17:31:38 +0100 [thread overview]
Message-ID: <eda9ad08-2742-4d4a-8566-f761565e07d7@proxmox.com> (raw)
In-Reply-To: <20230615080815.921858-1-d.csapak@proxmox.com>
Am 15/06/2023 um 10:08 schrieb Dominik Csapak:
> this field has a fixed height, which is too tall for the create wizard,
> and one cannot see the last entry when scrolling all the way down.
>
> to fix this, make it 20px shorter
was still broken in the german translation, as that takes up more space in
a label higher up in the panel.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> alternatively we could also increase the height in the create wizard
I went for that route for now, increasing that from 510 to 540 (4:3 ratio
to width).
> the optimal solution would be to improve the layouting in our
> wizard/inputpanel altogether so that it automatically gets the right
> height, but that is a non-trivial rework there. imho this should work
> fine as a stopgap fix for now
just out of interest, could setting a flex+maxHeight for the extra-flags
also have been an option?
next prev parent reply other threads:[~2023-11-06 16:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 8:08 Dominik Csapak
2023-06-15 8:10 ` Dominik Csapak
2023-11-06 16:31 ` Thomas Lamprecht [this message]
2023-11-07 7:50 ` Dominik Csapak
2023-11-07 7:56 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eda9ad08-2742-4d4a-8566-f761565e07d7@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox