From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH qemu 1/2] fix #4476: savevm-async: avoid looping without progress
Date: Tue, 21 Feb 2023 09:15:35 +0100 [thread overview]
Message-ID: <eda3e336-98b3-1ba9-90b8-cbad73f830e4@proxmox.com> (raw)
In-Reply-To: <20230126134614.117709-1-f.ebner@proxmox.com>
Am 26/01/2023 um 14:46 schrieb Fiona Ebner:
> when pend_postcopy is large. By definition, pend_postcopy won't
> decrease when iterating, so a value larger than the cutoff of 400000
> would lead to essentially empty iterations, filling up the state file
> until only 30 MiB + pending_size remain and the second half of the
> check would trigger.
>
> Avoid this, by not considering pend_postcopy for the cutoff to enter
> the final phase.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> Many thanks to Fabian for discussing the issue with me!
>
> ...vevm-async-for-background-state-snapshots.patch | 14 ++++++++------
> ...-PVE-add-optional-buffer-size-to-QEMUFile.patch | 6 +++---
> ...async-register-yank-before-migration_inco.patch | 4 ++--
> 3 files changed, 13 insertions(+), 11 deletions(-)
>
>
applied both patches, thanks!
prev parent reply other threads:[~2023-02-21 8:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 13:46 [pve-devel] " Fiona Ebner
2023-01-26 13:46 ` [pve-devel] [PATCH qemu 2/2] savevm-async: keep more free space when entering final stage Fiona Ebner
2023-02-09 9:30 ` [pve-devel] [PATCH qemu 1/2] fix #4476: savevm-async: avoid looping without progress Fiona Ebner
2023-02-21 8:15 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eda3e336-98b3-1ba9-90b8-cbad73f830e4@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox