From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Nicolas Frey <n.frey@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-manager 1/2] ui: remove excess '}' at the end of snapshot subject
Date: Thu, 2 Oct 2025 10:35:47 +0200 [thread overview]
Message-ID: <ed63af27-4af2-415d-b2e1-31b628810d01@proxmox.com> (raw)
In-Reply-To: <20250930130134.101875-2-n.frey@proxmox.com>
Minor nit: the commit title could be improved. I'd suggest adding a
second prefix like "ui: guest snapshot: ..." and "... of window title"
instead of the rather unclear "snapshot subject" at the end of the sentence.
Am 30.09.25 um 3:01 PM schrieb Nicolas Frey:
> Noticed one too many curly braces in the Snapshot window title.
>
> Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> www/manager6/window/Snapshot.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/manager6/window/Snapshot.js b/www/manager6/window/Snapshot.js
> index 80eaa251..a2134bd3 100644
> --- a/www/manager6/window/Snapshot.js
> +++ b/www/manager6/window/Snapshot.js
> @@ -146,7 +146,7 @@ Ext.define('PVE.window.Snapshot', {
> me.vmid,
> me.vmname,
> );
> - subject = `${guestTypeStr} ${formattedGuestIdentifier} ${gettext('Snapshot')}}`;
> + subject = `${guestTypeStr} ${formattedGuestIdentifier} ${gettext('Snapshot')}`;
> me.method = 'POST';
> me.showTaskViewer = true;
> } else {
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-10-02 8:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-30 13:01 [pve-devel] [PATCH pve-manager 0/2] ui: fix #6209: create snapshots and backups from context menu Nicolas Frey
2025-09-30 13:01 ` [pve-devel] [PATCH pve-manager 1/2] ui: remove excess '}' at the end of snapshot subject Nicolas Frey
2025-10-02 8:35 ` Fiona Ebner [this message]
2025-09-30 13:01 ` [pve-devel] [PATCH pve-manager 2/2] ui: fix #6209: create snapshots and backups from context menu Nicolas Frey
2025-10-02 8:36 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed63af27-4af2-415d-b2e1-31b628810d01@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=n.frey@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox