public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Daniel Kral <d.kral@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Daniel Herzig <d.herzig@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-esxi-import-tools] fix #6347: do not break vm listing on invalid configs
Date: Wed, 23 Apr 2025 15:28:45 +0200	[thread overview]
Message-ID: <ed50bdc3-d508-42e4-b3ed-47848eab4e5a@proxmox.com> (raw)
In-Reply-To: <20250423130315.360403-1-d.herzig@proxmox.com>

On 4/23/25 15:03, Daniel Herzig wrote:
> Move the queries for vCLS machines and empty datastore strings into
> the already existing try-except routine to save `listvms.py` from
> breaking when `vm.config` is `None`.
> 
> Do not store the result of the `any` function in a variable anymore,
> do the same for the datastore query to shorten code.
> 
> Prepare more verbose logging.
> 
> Signed-off-by: Daniel Herzig <d.herzig@proxmox.com>

Oops, I should have prefixed my patch with a "fix" at least, but I've 
sent two patches some days ago for this ;):

https://lore.proxmox.com/pve-devel/20250411150634.253684-1-d.kral@proxmox.com/T/#u

But it's also good to just extend the scope of the try-catch here 
without the additional check for whether the vm.config has a value or not.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-04-23 13:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-23 13:03 Daniel Herzig
2025-04-23 13:28 ` Daniel Kral [this message]
2025-04-23 14:04   ` Daniel Herzig
2025-04-23 14:45     ` Daniel Kral
2025-04-23 15:17       ` Daniel Herzig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed50bdc3-d508-42e4-b3ed-47848eab4e5a@proxmox.com \
    --to=d.kral@proxmox.com \
    --cc=d.herzig@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal