public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH widget-toolkit 4/4] panel: add StatusView from PVE
Date: Thu, 22 Apr 2021 20:38:33 +0200	[thread overview]
Message-ID: <ec6eccd6-0d9c-0e09-2436-b516ef87cd8a@proxmox.com> (raw)
In-Reply-To: <20210419110048.20791-5-d.csapak@proxmox.com>

On 19.04.21 13:00, Dominik Csapak wrote:
> with 2 minor fixups:
> * one lint error
> * binding of the 'updateValues' function in the event
>   (we want to avoid breaking this when used in a context where
>   a controller exists, in that case using a string will only look in
>   the controller and not in the component itself anymore, so use
>   the function directly)
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  src/Makefile            |   1 +
>  src/panel/StatusView.js | 125 ++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 126 insertions(+)
>  create mode 100644 src/panel/StatusView.js

applied, with a some unimportant cleanups and an important fix (or better said, workaround)
for the use in PVE, see below.

> diff --git a/src/panel/StatusView.js b/src/panel/StatusView.js
> new file mode 100644
> index 0000000..059508a
> --- /dev/null
> +++ b/src/panel/StatusView.js

> +    updateValues: function(store, records, success) {
> +	if (!success) {
> +	    return; // do not update if store load was not successful
> +	}
> +	var me = this;
> +	var itemsToUpdate = me.query('pmxInfoWidget');

does not finds the pveInfoWidgets from, well, PVE, and makes for a pretty boring
view there ;-)

> +
> +	itemsToUpdate.forEach(me.updateField, me);
> +
> +	me.updateTitle(store);
> +    },
> +





  reply	other threads:[~2021-04-22 18:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-19 11:00 [pve-devel] [PATCH widget-toolkit/pve-manager] move some code to widget-toolkit Dominik Csapak
2021-04-19 11:00 ` [pve-devel] [PATCH widget-toolkit 1/4] Utils: add several render functions from PVE Dominik Csapak
2021-04-19 11:00 ` [pve-devel] [PATCH widget-toolkit 2/4] bring over some icons " Dominik Csapak
2021-04-19 11:00 ` [pve-devel] [PATCH widget-toolkit 3/4] Utils: refactor updateColumns from pve-manager Dominik Csapak
2021-04-19 11:00 ` [pve-devel] [PATCH widget-toolkit 4/4] panel: add StatusView from PVE Dominik Csapak
2021-04-22 18:38   ` Thomas Lamprecht [this message]
2021-04-19 11:00 ` [pve-devel] [PATCH manager 1/4] ui: Utils: use render functions from widget-toolkit Dominik Csapak
2021-04-19 11:00 ` [pve-devel] [PATCH manager 2/4] ui: use some icons " Dominik Csapak
2021-04-19 11:00 ` [pve-devel] [PATCH manager 3/4] ui: Utils: use updateColumns " Dominik Csapak
2021-04-19 11:00 ` [pve-devel] [PATCH manager 4/4] ui: panel/StatusView: use from widget-toolkit instead Dominik Csapak
2021-04-22 18:41 ` [pve-devel] applied: [PATCH widget-toolkit/pve-manager] move some code to widget-toolkit Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec6eccd6-0d9c-0e09-2436-b516ef87cd8a@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal