public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH docs] qm: fix hookscript example
Date: Mon, 1 Feb 2021 11:53:24 +0100	[thread overview]
Message-ID: <ec33d2d2-cb81-2077-894d-e90b46eb7678@proxmox.com> (raw)
In-Reply-To: <805140b8-4f37-8645-1bba-5d6cfbcd382a@proxmox.com>



On 2/1/21 11:47 AM, Thomas Lamprecht wrote:
> 
> but this is a style fix only, or? As a single minus always works for options
> in CLIHandler based executables (we have no short-opts there).

yes it is basically a style fix. It works with one dash. What does not work with one dash though (tested quickly) is the auto completion of the parameter.

> 
> On 01.02.21 11:06, Aaron Lauterer wrote:
>> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
>> ---
>>   qm.adoc | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/qm.adoc b/qm.adoc
>> index 333b2e6..e0cce2b 100644
>> --- a/qm.adoc
>> +++ b/qm.adoc
>> @@ -1333,7 +1333,7 @@ Hookscripts
>>   
>>   You can add a hook script to VMs with the config property `hookscript`.
>>   
>> - qm set 100 -hookscript local:snippets/hookscript.pl
>> + qm set 100 --hookscript local:snippets/hookscript.pl
>>   
>>   It will be called during various phases of the guests lifetime.
>>   For an example and documentation see the example script under
>>
> 




  reply	other threads:[~2021-02-01 10:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-01 10:06 Aaron Lauterer
2021-02-01 10:47 ` Thomas Lamprecht
2021-02-01 10:53   ` Aaron Lauterer [this message]
2021-04-24 17:45 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec33d2d2-cb81-2077-894d-e90b46eb7678@proxmox.com \
    --to=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal