public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server v2 2/2] test: Adapt to changes in network scripts location
Date: Mon, 7 Apr 2025 17:31:08 +0200	[thread overview]
Message-ID: <ec1eeaa4-fa89-4436-b6f1-d2b91ae171f4@proxmox.com> (raw)
In-Reply-To: <20250218133206.318155-2-m.sandoval@proxmox.com>

Am 18.02.25 um 14:32 schrieb Maximiliano Sandoval:
> From the previous commit.

argh, I misread this, but without this the previous commit breaks the build :(

Never do that _please_, rather apply changes required for the testing system
with the commit that causes the need for those changes in the first place,
all else is just always *plain wrong*.

Fixed now in a follow-up.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-04-07 15:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-18 13:32 [pve-devel] [PATCH qemu-server v2 1/2] vm-network-scripts: move scripts to /usr/libexec Maximiliano Sandoval
2025-02-18 13:32 ` [pve-devel] [PATCH qemu-server v2 2/2] test: Adapt to changes in network scripts location Maximiliano Sandoval
2025-04-07 15:31   ` Thomas Lamprecht [this message]
2025-04-07 14:04 ` [pve-devel] applied: [PATCH qemu-server v2 1/2] vm-network-scripts: move scripts to /usr/libexec Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec1eeaa4-fa89-4436-b6f1-d2b91ae171f4@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal