From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve-xtermjs] xtermjs: try to detect hardware support for webgl2
Date: Wed, 25 Oct 2023 19:02:39 +0200 [thread overview]
Message-ID: <ebb4a78e-752d-4dbb-8888-03bb01e4a643@proxmox.com> (raw)
In-Reply-To: <20231025090859.2235027-1-d.csapak@proxmox.com>
Am 25/10/2023 um 11:08 schrieb Dominik Csapak:
> with the new webgl renderer, chrome/chromium has buggy software support for
> emulating this (see [0]), so we have to detect that manually and prevent
> loading the addon. This fixes the issue that on chrome without hw
> support, it would not always render every character.
>
> Firefox does not have support for a software renderer and the
> loading/detection throws an exception, falling back to the default
> renderer.
>
> 0: https://github.com/xtermjs/xterm.js/issues/4574
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> tested with and without webgl hardware support on firefox/chrome/chromium
>
> xterm.js/src/main.js | 22 ++++++++++++++++++++--
> 1 file changed, 20 insertions(+), 2 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-10-25 17:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 9:08 [pve-devel] " Dominik Csapak
2023-10-25 17:02 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebb4a78e-752d-4dbb-8888-03bb01e4a643@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox