From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] fix #3861: migrate: fix live migration when cloud-init changes storage
Date: Thu, 28 Apr 2022 18:35:58 +0200 [thread overview]
Message-ID: <eb70e98e-dd32-8dc4-8a39-1db82044562c@proxmox.com> (raw)
In-Reply-To: <20220428113737.105842-1-f.ebner@proxmox.com>
On 28.04.22 13:37, Fabian Ebner wrote:
> Generalizes fd95d780 ("migrate: send updated TPM state volid to target
> node") to also handle other offline migrated disks appearing in the
> VM config, which currently should only be cloud-init.
>
> Breaks migration new -> old under similar (edge-case-)conditions as
> fd95d780 did.
>
> Keep sending the 'tpmstate0' STDIN parameter to avoid breaking new ->
> old in the scenario fd95d780 fixed.
>
> Keep parsing the vm_start 'tpmstate0' STDIN parameter to avoid
> breaking old -> new, and to be able to keep sending it.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> PVE/API2/Qemu.pm | 10 ++++++----
> PVE/QemuMigrate.pm | 19 ++++++++++++++-----
> PVE/QemuServer.pm | 15 +++++++++------
> 3 files changed, 29 insertions(+), 15 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2022-04-28 16:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 11:37 [pve-devel] " Fabian Ebner
2022-04-28 16:35 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb70e98e-dd32-8dc4-8a39-1db82044562c@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox