From: Fiona Ebner <f.ebner@proxmox.com>
To: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH v2 1/2] build: include Hyper-V enlightenments in CPUID flags list
Date: Tue, 2 Jun 2026 15:34:56 +0200 [thread overview]
Message-ID: <eb0be806-2bae-4245-a1ea-9418c06cafb7@proxmox.com> (raw)
In-Reply-To: <lxqwfcfxnsiwfnv4odnmk3wjv5qxx7tjwvajop3shpixe6437g@jiev4urm3u4u>
Am 02.06.26 um 3:13 PM schrieb Arthur Bied-Charreton:
> On Tue, Jun 02, 2026 at 02:14:05PM +0200, Fiona Ebner wrote:
>> Am 01.06.26 um 9:16 AM schrieb Arthur Bied-Charreton:
>>> +};
>>>
>>> - s/^\s+//;
>>> +my $flags = {};
>>>
>>> - push @flags, split(/\s+/);
>>> +<$out>;
>>
>> Nit: Could match the beginning of the line to see that it's the single
>> QMP message we expect. And die if there is anything else for catching
>> any unexpected warnings/messages.
>>
> just to clarify, by beginning of the line you just mean the QMP key in
> the return object right?
>
> ```
> {"QMP": {"version": {"qemu": {"micro": 0, "minor": 0, "major": 11}, "package": "pve-qemu-kvm_11.0.0-4"}, "capabilities": []}}
> ```
Yes, just that there's a QMP JSON info line, I would even say, the
contents don't matter too much here ^^
> or do you want to fail on new pve-qemu-kvm versions?
No.
next prev parent reply other threads:[~2026-06-02 13:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 7:08 [PATCH pve-qemu v2 0/2] include Hyper-V enlightenments in Arthur Bied-Charreton
2026-06-01 7:08 ` [PATCH v2 1/2] build: include Hyper-V enlightenments in CPUID flags list Arthur Bied-Charreton
2026-06-02 12:14 ` Fiona Ebner
2026-06-02 13:13 ` Arthur Bied-Charreton
2026-06-02 13:34 ` Fiona Ebner [this message]
2026-06-01 7:08 ` [PATCH v2 2/2] build: fail when recognized CPUID flags list changes Arthur Bied-Charreton
2026-06-03 7:12 ` superseded: [PATCH pve-qemu v2 0/2] include Hyper-V enlightenments in Arthur Bied-Charreton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb0be806-2bae-4245-a1ea-9418c06cafb7@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=a.bied-charreton@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox