public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Mira Limbeck <m.limbeck@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH container 1/1] Fix #6989: cloudinit: Enable joliet ISO extension for config disks
Date: Thu, 6 Nov 2025 14:17:04 +0100	[thread overview]
Message-ID: <eb067edb-eab6-42f2-a65d-4caf86f59bd0@proxmox.com> (raw)
In-Reply-To: <mailman.527.1762178392.362.pve-devel@lists.proxmox.com>

Thank you for the patch!

The repository is wrong, it should be qemu-server not container.


I couldn't get a Windows Server 2022 to work with NoCloud to test it
directly.
But it continued to work with the default (citype: configdrive2) even
after the patch.
And a Ubuntu 25.10 cloud image also worked with its default (citype:
nocloud).

I also verified that Windows sees the files with the correct name after
this patch.

So the patch looks good to me.

Consider this:
Reviewed-by: Mira Limbeck <m.limbeck@proxmox.com>
Tested-by: Mira Limbeck <m.limbeck@proxmox.com>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-11-06 13:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20251103113900.140922-1-info@ebner-markus.de>
2025-11-03 11:38 ` Markus Ebner via pve-devel
2025-11-06 13:17   ` Mira Limbeck [this message]
2025-11-06 18:41   ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb067edb-eab6-42f2-a65d-4caf86f59bd0@proxmox.com \
    --to=m.limbeck@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal