public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] ui: qemu/AgentIPView: also filter out 0:0:0:0:0:0
@ 2020-09-22 14:04 Dominik Csapak
  2020-09-23 13:10 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2020-09-22 14:04 UTC (permalink / raw)
  To: pve-devel

it seems that some guest-agents format an non-existant mac adress
differently (e.g. macos, see [0]) so filter that also out

0: https://forum.proxmox.com/threads/macos-vm-optischer-makel.76263/

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/qemu/AgentIPView.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/www/manager6/qemu/AgentIPView.js b/www/manager6/qemu/AgentIPView.js
index fb423c98..32e8b08d 100644
--- a/www/manager6/qemu/AgentIPView.js
+++ b/www/manager6/qemu/AgentIPView.js
@@ -104,7 +104,8 @@ Ext.define('PVE.qemu.AgentIPView', {
 	var ips = [];
 	nics.forEach(function(nic) {
 	    if (nic['hardware-address'] &&
-		nic['hardware-address'] != '00:00:00:00:00:00') {
+		nic['hardware-address'] != '00:00:00:00:00:00' &&
+		nic['hardware-address'] != '0:0:0:0:0:0') {
 
 		var nic_ips = nic['ip-addresses'] || [];
 		nic_ips.forEach(function(ip) {
-- 
2.20.1





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH manager] ui: qemu/AgentIPView: also filter out 0:0:0:0:0:0
  2020-09-22 14:04 [pve-devel] [PATCH manager] ui: qemu/AgentIPView: also filter out 0:0:0:0:0:0 Dominik Csapak
@ 2020-09-23 13:10 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2020-09-23 13:10 UTC (permalink / raw)
  To: Proxmox VE development discussion, Dominik Csapak

On 22.09.20 16:04, Dominik Csapak wrote:
> it seems that some guest-agents format an non-existant mac adress
> differently (e.g. macos, see [0]) so filter that also out
> 
> 0: https://forum.proxmox.com/threads/macos-vm-optischer-makel.76263/
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/manager6/qemu/AgentIPView.js | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-23 13:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-22 14:04 [pve-devel] [PATCH manager] ui: qemu/AgentIPView: also filter out 0:0:0:0:0:0 Dominik Csapak
2020-09-23 13:10 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal