[pve-devel] [PATCH installer] highlight focused button with dark orange

[pve-devel] [PATCH installer] highlight focused button with dark orange

[Oguz Bektas]

idea was from community forum [0]

arbitrary css can be used to style the installer, for now just add the
highlight feature.

[0]:
https://forum.proxmox.com/threads/proxmox-installation-eye-catching-color.87440

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
 proxinstall | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/proxinstall b/proxinstall
index 03f6ec7..e79f0c6 100755
--- a/proxinstall
+++ b/proxinstall
@@ -25,6 +25,13 @@ use POSIX ":sys_wait_h";
 
 use ProxmoxInstallerSetup;
 
+my $css_provider = Gtk3::CssProvider->new();
+my $display = Gtk3::Gdk::Display::get_default;
+my $screen = Gtk3::Gdk::Display::get_default_screen($display);
+Gtk3::StyleContext::add_provider_for_screen($screen, $css_provider, 600);
+my $prox_theme = "button:focus {\nbackground-color: #000000;\ncolor: #FF4500;\n}";
+$css_provider->load_from_data($prox_theme);
+
 my $setup = ProxmoxInstallerSetup::setup();
 
 my $opt_testmode;
-- 
2.20.1

Re: [pve-devel] [PATCH installer] highlight focused button with dark orange

[Stoiko Ivanov]

Thanks for the patch!
can see that it could help users, who (have to) navigate the installer
with a keyboard...

gave it a (very quick) spin with the check-pve make-target - in
general it seems ok to me

one thing that does not look too nice to me is the +/- buttons for integer
entry (click on Options in the HD selection window) - maybe those could be
a bit more toned down (only change the foreground in that case)



On Mon, 12 Apr 2021 16:28:38 +0200
Oguz Bektas <o.bektas@proxmox.com> wrote:

> idea was from community forum [0]
> 
> arbitrary css can be used to style the installer, for now just add the
> highlight feature.
> 
> [0]:
> https://forum.proxmox.com/threads/proxmox-installation-eye-catching-color.87440
> 
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
>  proxinstall | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/proxinstall b/proxinstall
> index 03f6ec7..e79f0c6 100755
> --- a/proxinstall
> +++ b/proxinstall
> @@ -25,6 +25,13 @@ use POSIX ":sys_wait_h";
>  
>  use ProxmoxInstallerSetup;
>  
> +my $css_provider = Gtk3::CssProvider->new();
> +my $display = Gtk3::Gdk::Display::get_default;
> +my $screen = Gtk3::Gdk::Display::get_default_screen($display);
> +Gtk3::StyleContext::add_provider_for_screen($screen, $css_provider, 600);
> +my $prox_theme = "button:focus {\nbackground-color: #000000;\ncolor: #FF4500;\n}";
> +$css_provider->load_from_data($prox_theme);
> +
>  my $setup = ProxmoxInstallerSetup::setup();
>  
>  my $opt_testmode;

Re: [pve-devel] [PATCH installer] highlight focused button with dark orange

[Thomas Lamprecht]

On 12.04.21 16:28, Oguz Bektas wrote:
> idea was from community forum [0]
> 
> arbitrary css can be used to style the installer, for now just add the
> highlight feature.

Not completely arbitrary, but yeah, most common stuff is
actually supported.

Anyway, I'd rather avoid pulling in such (under the hood) complex features,
and their actual issue would be rather solved with the planned terminal based
user interface (TUI).

Further, this may not be to friendly for people with color-sight impairments,
the default GTK theme is normally already designed with accessibility in mind,
changing styling may break assumptions baked in there.

Also, as Stoiko mentioned, the button class is used in more places than just
the obvious ones, so more subtle breakage/weirdness can happen.

Focused buttons are already highlighted, and the Alt+<underlined-key> helper
is available too for keyboard only installations, as documented in:
https://pve.proxmox.com/pve-docs/chapter-pve-installation.html#installation_installer

So no, I do not want to include such styling patches.

> 
> [0]:
> https://forum.proxmox.com/threads/proxmox-installation-eye-catching-color.87440
> 
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
>  proxinstall | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/proxinstall b/proxinstall
> index 03f6ec7..e79f0c6 100755
> --- a/proxinstall
> +++ b/proxinstall
> @@ -25,6 +25,13 @@ use POSIX ":sys_wait_h";
>  
>  use ProxmoxInstallerSetup;
>  
> +my $css_provider = Gtk3::CssProvider->new();
> +my $display = Gtk3::Gdk::Display::get_default;
> +my $screen = Gtk3::Gdk::Display::get_default_screen($display);
> +Gtk3::StyleContext::add_provider_for_screen($screen, $css_provider, 600);
> +my $prox_theme = "button:focus {\nbackground-color: #000000;\ncolor: #FF4500;\n}";
> +$css_provider->load_from_data($prox_theme);
> +
>  my $setup = ProxmoxInstallerSetup::setup();
>  
>  my $opt_testmode;
>