Re: [pve-devel] [PATCH container 1/1] Setup: add NixOS support

Re: [pve-devel] [PATCH container 1/1] Setup: add NixOS support

[Thomas Lamprecht]

thanks for your contribution!

meta:
The commit is missing your Signed-off-by and, FWICT, we don't have yet a
signed CLA - if that's the case please check:
https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright

On 13.02.22 14:27, Harikrishnan R wrote:
> Distro detection is done through the presence of a /nix folder.

seems a bit arbitrary and we only still do such things in general for legacy
reasons, new distros should be able to get the info from the (somewhat) standard
/etc/os-release file - or is that not guaranteed for Nix

Note that "nix" is a valid word in some languages, e.g., in german so finding
such a folder, in another distro is, while unlikely, not completely impossible.

> NixOS typically uses a script-based network configuration system
> that isn't easy to configure from the outside. LXC templates

Can be ok for an initial inclusion, and while networking itself doesn't seems
to bad to generate [0], the level of how elaborate that should parse and
cooperate with existing Nix statements can naturally complicate that, but
adding a fixed output at the top of the file into a comment marked section, like
we do already for other distros, should allow to override it by the user
internally.

[0]: https://nixos.wiki/wiki/Networking

> generated for proxmox are instead expected to use systemd-networkd.


So, basically this is just like a unmanaged CT but with systemd network setup?
Not sure if that adds /that/ much value over unmanaged, or maybe better said,
as currently implements this would rather be a "sd-network" ostype.
On the other hand, such simple distro types have not /that/ much cost to maintain
either, so not intending to block this - albeit some more elaborate implementation
would be welcomed :-)