From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: Re: [pve-devel] [PATCH guest-common v3 1/1] replication: remove logging when freezing/thawing
Date: Thu, 4 Dec 2025 15:03:11 +0100 [thread overview]
Message-ID: <e98f00be-398d-4f5a-9f96-77a39d231362@proxmox.com> (raw)
In-Reply-To: <20251014122718.374205-10-m.sandoval@proxmox.com>
Am 14.10.25 um 2:27 PM schrieb Maximiliano Sandoval:
> This is handled now by the class' __snapshot_freeze.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> src/PVE/Replication.pm | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/src/PVE/Replication.pm b/src/PVE/Replication.pm
> index ba4c2c1..1b31ae2 100644
> --- a/src/PVE/Replication.pm
> +++ b/src/PVE/Replication.pm
> @@ -376,7 +376,6 @@ sub replicate {
>
> # freeze filesystem for data consistency
> if ($freezefs) {
> - $logfunc->("freeze guest filesystem");
> $guest_class->__snapshot_freeze($vmid, 0);
> }
>
> @@ -395,7 +394,6 @@ sub replicate {
>
> # thaw immediately
> if ($freezefs) {
> - $logfunc->("thaw guest filesystem");
> $guest_class->__snapshot_freeze($vmid, 1);
> }
>
Using $logfunc->() makes those messages be part of the replication log,
while the ones with 'print' in the $guest_class will not be.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-12-04 14:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 12:27 [pve-devel] [PATCH container/guest-common/qemu-server v3 0/9] fix #1964: add setting to always disable freezing a guest Maximiliano Sandoval
2025-10-14 12:27 ` [pve-devel] [PATCH qemu-server v3 1/7] add a guest-fsfreeze qga setting Maximiliano Sandoval
2025-12-04 14:02 ` Fiona Ebner
2025-10-14 12:27 ` [pve-devel] [PATCH qemu-server v3 2/7] block job: mirror: follow guest-fsfreeze setting Maximiliano Sandoval
2025-12-04 14:02 ` Fiona Ebner
2025-10-14 12:27 ` [pve-devel] [PATCH qemu-server v3 3/7] fix #1964: follow guest-fsfreeze setting on check freeze needed Maximiliano Sandoval
2025-10-14 12:27 ` [pve-devel] [PATCH qemu-server v3 4/7] log when issuing a guest-fsfreeze command Maximiliano Sandoval
2025-12-04 14:03 ` Fiona Ebner
2025-10-14 12:27 ` [pve-devel] [PATCH qemu-server v3 5/7] block job: mirror: reword fsfreeze log entry Maximiliano Sandoval
2025-10-14 12:27 ` [pve-devel] [PATCH qemu-server v3 6/7] block job: log if fs-freeze is skipped due to config Maximiliano Sandoval
2025-10-14 12:27 ` [pve-devel] [PATCH qemu-server v3 7/7] deprecate freeze-fs-on-backup qga setting Maximiliano Sandoval
2025-10-14 12:27 ` [pve-devel] [PATCH container v3 1/1] log when freezing/thawing filesystem Maximiliano Sandoval
2025-12-04 14:03 ` Fiona Ebner
2025-10-14 12:27 ` [pve-devel] [PATCH guest-common v3 1/1] replication: remove logging when freezing/thawing Maximiliano Sandoval
2025-12-04 14:03 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e98f00be-398d-4f5a-9f96-77a39d231362@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox