public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com,
	"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 1/2] api: return UPID in template call
Date: Fri, 10 Sep 2021 10:32:14 +0200	[thread overview]
Message-ID: <e900e4e5-b103-a6fb-00bf-2c0e98f4f226@proxmox.com> (raw)
In-Reply-To: <20210910074820.1477562-1-f.gruenbichler@proxmox.com>

The same issues are present for the corresponding API call in 
pve-container ;)

Both patches
Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>

Am 10.09.21 um 09:48 schrieb Fabian Grünbichler:
> as reported on the forum, this is currently missing, making status
> queries via the API impossible:
> 
> https://forum.proxmox.com/threads/create-vm-via-api-interface.95942/#post-416084
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
>   PVE/API2/Qemu.pm | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
> index ef0d877..0a23525 100644
> --- a/PVE/API2/Qemu.pm
> +++ b/PVE/API2/Qemu.pm
> @@ -4336,7 +4336,10 @@ __PACKAGE__->register_method({
>   
>   	},
>       },
> -    returns => { type => 'null'},
> +    returns => {
> +	type => 'string',
> +	description => "the task ID.",
> +    },
>       code => sub {
>   	my ($param) = @_;
>   
> @@ -4375,8 +4378,7 @@ __PACKAGE__->register_method({
>   	    return $rpcenv->fork_worker('qmtemplate', $vmid, $authuser, $realcmd);
>   	};
>   
> -	PVE::QemuConfig->lock_config($vmid, $updatefn);
> -	return;
> +	return PVE::QemuConfig->lock_config($vmid, $updatefn);
>       }});
>   
>   __PACKAGE__->register_method({
> 




  parent reply	other threads:[~2021-09-10  8:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-10  7:48 Fabian Grünbichler
2021-09-10  7:48 ` [pve-devel] [PATCH qemu-server 2/2] api: template: invert lock and fork Fabian Grünbichler
2021-10-04  7:46   ` [pve-devel] applied: " Thomas Lamprecht
2021-09-10  8:32 ` Fabian Ebner [this message]
2021-09-10 10:03   ` [pve-devel] [PATCH qemu-server 1/2] api: return UPID in template call Fabian Grünbichler
2021-09-10  9:26 ` Dominik Csapak
2021-09-10 10:00   ` Thomas Lamprecht
2021-09-10 10:03   ` Fabian Grünbichler
2021-10-04  7:46 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e900e4e5-b103-a6fb-00bf-2c0e98f4f226@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal