Re: [pve-devel] [PATCH pve-access-control] resource pools: add resource pool cli commands

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 28.01.21 12:01, Dylan Whyte wrote:
> Add commands for creating, modifying, listing, and deleting resource
> pools.
> 
> Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
> ---
>  PVE/CLI/pveum.pm | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/PVE/CLI/pveum.pm b/PVE/CLI/pveum.pm
> index c98ddde..0540b85 100755
> --- a/PVE/CLI/pveum.pm
> +++ b/PVE/CLI/pveum.pm
> @@ -10,6 +10,7 @@ use PVE::API2::Group;
>  use PVE::API2::Role;
>  use PVE::API2::ACL;
>  use PVE::API2::AccessControl;
> +use PVE::API2::Pool;
>  use PVE::API2::Domains;
>  use PVE::CLIFormatter;
>  use PVE::CLIHandler;
> @@ -145,7 +146,12 @@ our $cmddef = {
>  	delete => [ 'PVE::API2::ACL', 'update_acl', ['path'], { delete => 1 }],
>  	list   => [ 'PVE::API2::ACL', 'read_acl', [], {}, $print_api_result, $PVE::RESTHandler::standard_output_options],
>      },
> -
> +    pool => {
> +	add => [ 'PVE::API2::Pool', 'create_pool', ['poolid'] ],
> +	modify => [ 'PVE::API2::Pool', 'update_pool', ['poolid'] ],
> +	delete => [ 'PVE::API2::Pool', 'delete_pool', ['poolid'] ],
> +	list   => [ 'PVE::API2::Pool', 'index', [], {}, $print_api_result, $PVE::RESTHandler::standard_output_options],
> +    },
>      realm => {
>  	add    => [ 'PVE::API2::Domains', 'create', ['realm'] ],
>  	modify => [ 'PVE::API2::Domains', 'update', ['realm'] ],
> @@ -176,6 +182,10 @@ our $cmddef = {
>  
>      aclmod => { alias => 'acl modify' },
>      acldel => { alias => 'acl delete' },
> +
> +    pooladd => { alias => 'pool add' },
> +    poolmod => { alias => 'pool modify' },
> +    pooldel => { alias => 'pool delete' },

Those aliases are only for backward compatibility for the old version, from
when we introduced sub-commands. New commands do not need them as we prefer
sub-commands.

>  };
>  
>  1;
>