From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH 1/2] use anyhow for result/error
Date: Fri, 28 Jan 2022 09:21:00 +0100 [thread overview]
Message-ID: <e8c1c439-bdae-2170-6098-8c5a4b2bbfd0@proxmox.com> (raw)
In-Reply-To: <0aa4348a-ccf1-f5e9-5e21-b69d079f0cb0@proxmox.com>
On 27.01.22 13:39, Dominik Csapak wrote:
> looks sane and works (tested on pve & pbs)
> did not push them myself since the ldd diff made it
> necessary that i edited the patch file before applying locally...
oops, yeah makes sense - I now added '> ' quoting in front of it to avoid
that.
> so, for both patches:
>
> Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
> Tested-by: Dominik Csapak <d.csapak@proxmox.com>
Thanks! I added those for the first patch but I had to change 2/2 slightly,
as ureq returns an error-result for all responses > 400 and so I had to
match that to get it to print our error and strictly allow only 200 codes.
prev parent reply other threads:[~2022-01-28 8:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 18:10 [pve-devel] " Thomas Lamprecht
2022-01-26 18:10 ` [pve-devel] [PATCH 2/2] switch from curl to ureq Thomas Lamprecht
2022-01-27 12:39 ` [pve-devel] [PATCH 1/2] use anyhow for result/error Dominik Csapak
2022-01-28 8:21 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8c1c439-bdae-2170-6098-8c5a4b2bbfd0@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox