From: Stefan Hanreich <s.hanreich@proxmox.com>
To: Friedrich Weber <f.weber@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-manager] postinst: Filter RADOS block devices
Date: Thu, 14 Dec 2023 10:55:17 +0100 [thread overview]
Message-ID: <e87f3679-2f61-4c81-8ee3-7a81b57d973c@proxmox.com> (raw)
In-Reply-To: <ce79c850-6122-4537-bff7-3a5b13270b57@proxmox.com>
On 12/14/23 10:34, Friedrich Weber wrote:
> Not sure how we could extend the global_filter in a reliable way if it
> is customized ... worst case, it might be an option to only rewrite the
> LVM config if it is unchanged (plus our ZFS zvol addition), and leave
> custom configs alone (and add a hint in the upgrade guide)?
Yes, at this point I'm also not sure there is a sane way to handle this.
Alternativel we could add a check to pve7to8, add a note to the release
notes and *maybe* check this in the postinst as well.
next prev parent reply other threads:[~2023-12-14 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 15:35 Stefan Hanreich
2023-12-13 17:07 ` Stefan Hanreich
2023-12-14 9:34 ` Friedrich Weber
2023-12-14 9:55 ` Stefan Hanreich [this message]
2023-12-14 9:56 ` Stefan Hanreich
2023-12-14 10:17 ` Friedrich Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e87f3679-2f61-4c81-8ee3-7a81b57d973c@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=f.weber@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox