From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH proxmox-apt 1/1] standard repos: allow conversion from handle and improve information
Date: Wed, 30 Jun 2021 20:46:27 +0200 [thread overview]
Message-ID: <e865f9ab-59ef-aaeb-07eb-58b26d545287@proxmox.com> (raw)
In-Reply-To: <20210630150754.9921-2-f.ebner@proxmox.com>
On 30.06.21 17:07, Fabian Ebner wrote:
> Add a description for the handle, which can be useful to display
> alongside the name. The descriptions are essentially the first
> sentence from PVE's "Package Repositories" docs, but without the
> product name.
>
> Also drop the " Repository" suffix from the names, as it's not useful,
> but can be ugly: e.g. for the UI when the label already is
> 'Repository:'.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> src/repositories/mod.rs | 42 ++++-------------------
> src/repositories/standard.rs | 64 +++++++++++++++++++++++++++++++-----
> tests/repositories.rs | 42 ++++-------------------
> 3 files changed, 69 insertions(+), 79 deletions(-)
>
>
applied, thanks!
next prev parent reply other threads:[~2021-06-30 18:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 15:07 [pve-devel] [PATCH-SERIES proxmox-apt/proxmox-widget-toolkit] Spawn a window when adding a repository Fabian Ebner
2021-06-30 15:07 ` [pve-devel] [PATCH proxmox-apt 1/1] standard repos: allow conversion from handle and improve information Fabian Ebner
2021-06-30 18:46 ` Thomas Lamprecht [this message]
2021-06-30 15:07 ` [pve-devel] [RFC proxmox-widget-toolkit 1/1] node: apt: spawn a window for adding repository Fabian Ebner
2021-06-30 19:31 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e865f9ab-59ef-aaeb-07eb-58b26d545287@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox