From: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>,
"t.lamprecht@proxmox.com" <t.lamprecht@proxmox.com>,
"aderumier@odiso.com" <aderumier@odiso.com>
Subject: Re: [pve-devel] [PATCH pve-cluster] pve-cluster.service : remove 127.0.1.1 from /etc/hosts
Date: Wed, 28 Jun 2023 07:47:47 +0000 [thread overview]
Message-ID: <e85522c8a61f1e161fa0796af0c9abdd799c8704.camel@groupe-cyllene.com> (raw)
In-Reply-To: <6fd43966-6917-3cb4-e7dd-53cbae3b3ce2@proxmox.com>
> >
> > [Service]
> > +ExecStartPre=/usr/bin/sed -i '/127.0.1.1/d' /etc/hosts
>
> .. and so is this, messing with hosts on every pve-cluster start or
> update..
>
> So no, please don't, messing with such things can be really subtle!
ok, I was not sure.
>
> Let's rather improve pmxcfs logic for getting the non-local IP
> configured on
> a node via getaddrinfo with the ALL flag and filtering out local
> IPs..
oh, I didn't known than getaddrinfo could return multiple ips.
(I thinked it was doing a simple dns resolution)
I'll look at that, thanks !
next prev parent reply other threads:[~2023-06-28 7:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 6:06 Alexandre Derumier
2023-06-28 7:28 ` Thomas Lamprecht
2023-06-28 7:47 ` DERUMIER, Alexandre [this message]
2023-06-28 8:13 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e85522c8a61f1e161fa0796af0c9abdd799c8704.camel@groupe-cyllene.com \
--to=alexandre.derumier@groupe-cyllene.com \
--cc=aderumier@odiso.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox