Re: [pve-devel] applied: [PATCH docs v2 1/6] ceph: add anchors for use in troubleshooting section

[Aaron Lauterer <a.lauterer@proxmox.com>]

On  2025-03-26  11:20, Max Carrara wrote:
> On Mon Mar 24, 2025 at 5:42 PM CET, Aaron Lauterer wrote:
>>
>>
>> On  2025-02-05  11:08, Alexander Zeidler wrote:
>>> Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
>>> ---
>>> v2:
>>> * add two missing anchors to be usable via xref
>>>
>>>    pve-disk-health-monitoring.adoc | 1 +
>>>    pveceph.adoc                    | 8 ++++++++
>>>    pvecm.adoc                      | 1 +
>>>    3 files changed, 10 insertions(+)
>>>
>>>
>> thanks for the work to extend the docs!
>>
>> applied with some changes and follow-ups:
>>
>> * we do not want to break the anchor to the ceph recommendations. This
>> anchor is in use to redirect customers and users to ceph requirements.
>> Yes it is ugly, but we cannot change it so we keep it.
>> * I do not think that inline CLI commands are a good idea as they are
>> make the paragraph messy and harder to read and are hard to copy&paste.
>> Therefore, I rephrased those parts to have them in their own code blocks.
>> * rephrased the Destroy OSD section, mainly to also place the CLI
>> commands into code blocks and a few other things you can see in the
>> follow up commit.
> 
> Aw, without my R-b and T-b tags, unfortunately :(
> 
> Is there any reason in particular that they weren't added?

Me being blind. Sorry for that.

> 
>>
>>
>> _______________________________________________
>> pve-devel mailing list
>> pve-devel@lists.proxmox.com
>> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel