From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: [pve-devel] applied-series: [PATCH access-control/manager 0/4] fix #1148: nested pools
Date: Mon, 20 Nov 2023 12:27:04 +0100 [thread overview]
Message-ID: <e7pbnpozvgclxub2glduexywfajabexni6aok24rke4gjfctm4@zgrcf5smyqiq> (raw)
In-Reply-To: <20231120072242.75599-1-f.gruenbichler@proxmox.com>
applied series, bumped access control and manager's dep on it
On Mon, Nov 20, 2023 at 08:22:38AM +0100, Fabian Grünbichler wrote:
> this series extends the poolname to allow (for now) two '/' inside the
> name to nest pools like this:
>
> parent/child/grandchild
>
> since '/' is a bad character for path parameters, some API shuffling is
> needed. other approaches that were tried but discarded, or rejected
> outright:
> - urlencoding
> - systemd-escape
> - manual encoding/escaping
> - just encoding the parent/children in user.cfg, but not in the pool name
>
> switching over some of the UI pool lists to also nest them visually should
> be do-able as a follow-up.
>
> changes since RFC:
> - some style improvements, RE adaptation
>
> pve-access-control:
>
> Fabian Grünbichler (2):
> allow up to three levels of pool nesting
> pools: record parent/subpool information
>
> src/PVE/AccessControl.pm | 26 +++++++++++++++++++++++---
> src/test/parser_writer.pl | 4 ++++
> src/test/perm-test6.pl | 16 ++++++++++++++++
> src/test/test6.cfg | 5 +++++
> 4 files changed, 48 insertions(+), 3 deletions(-)
>
> pve-manager:
>
> Fabian Grünbichler (2):
> api: pools: support nested pools
> ui: pools: switch to new API endpoints
>
> PVE/API2/Pool.pm | 243 +++++++++++++++++++++++--------
> www/manager6/dc/PoolView.js | 3 +
> www/manager6/grid/PoolMembers.js | 14 +-
> www/manager6/pool/StatusView.js | 2 +-
> 4 files changed, 196 insertions(+), 66 deletions(-)
>
> --
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2023-11-20 11:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 7:22 [pve-devel] " Fabian Grünbichler
2023-11-20 7:22 ` [pve-devel] [PATCH access-control 1/2] fix #1148: allow up to three levels of pool nesting Fabian Grünbichler
2023-11-20 7:22 ` [pve-devel] [PATCH access-control 2/2] pools: record parent/subpool information Fabian Grünbichler
2023-11-20 7:22 ` [pve-devel] [PATCH manager 1/2] fix #1148: api: pools: support nested pools Fabian Grünbichler
2023-11-20 7:22 ` [pve-devel] [PATCH manager 2/2] ui: pools: switch to new API endpoints Fabian Grünbichler
2023-11-20 11:27 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7pbnpozvgclxub2glduexywfajabexni6aok24rke4gjfctm4@zgrcf5smyqiq \
--to=w.bumiller@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox