From: Filip Schauer <f.schauer@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH container] fix #4846: Avoid the outdated noacl mount option on ext4
Date: Fri, 23 Feb 2024 11:50:45 +0100 [thread overview]
Message-ID: <e7d91320-18ef-4659-b800-5b1b48bd0d4e@proxmox.com> (raw)
In-Reply-To: <43c10b65-9ba5-4e64-87d5-1ec7dd961b9b@proxmox.com>
A v2 of this patch is available:
https://lists.proxmox.com/pipermail/pve-devel/2024-February/061932.html
On 16/02/2024 14:59, Fiona Ebner wrote:
> Am 01.09.23 um 11:05 schrieb Filip Schauer:
>> Do not use the 'noacl' mount option when mounting a container disk with
>> an ext4 file system. The option was removed from the kernel in commit
>> 2d544ec923db
>>
>> Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
>> ---
>> src/PVE/LXC.pm | 10 +++++++---
>> 1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
>> index 1e9af0f..3ebce37 100644
>> --- a/src/PVE/LXC.pm
>> +++ b/src/PVE/LXC.pm
>> @@ -1764,9 +1764,6 @@ sub __mountpoint_mount {
>> }
>>
>> my $acl = $mountpoint->{acl};
>> - if (defined($acl)) {
>> - push @$optlist, ($acl ? 'acl' : 'noacl');
>> - }
>>
>> my $optstring = join(',', @$optlist);
> This is the last time optlist is read from, so the below hunk won't have
> any effect?
>
>> my $readonly = $mountpoint->{ro};
>> @@ -1787,6 +1784,13 @@ sub __mountpoint_mount {
>>
>> $format = 'iso' if $vtype eq 'iso'; # allow to handle iso files
>>
>> + # Avoid the outdated 'noacl' mount option on ext4 file systems
>> + if ($scfg->{type} ne 'zfspool') {
> While we only format Proxmox VE managed volumes with ext4, this mount
> code is potentially called for other FS types too. For example, I can
> manually format a mount point with BTRFS - where noacl is apparently
> still a valid option. While a niche use case, and potentially something
> we could risk breaking until somebody complains, maybe we can detect FS
> type and filter based on that?
>
>> + push @$optlist, 'acl' if $acl;
>> + } elsif (defined($acl)) {
>> + push @$optlist, ($acl ? 'acl' : 'noacl');
>> + }
>> +
>> if ($format eq 'subvol') {
>> if ($mount_path) {
>> my (undef, $name) = PVE::Storage::parse_volname($storage_cfg, $volid);
prev parent reply other threads:[~2024-02-23 10:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 9:05 Filip Schauer
2024-02-14 13:57 ` Filip Schauer
2024-02-16 13:59 ` Fiona Ebner
2024-02-23 10:50 ` Filip Schauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7d91320-18ef-4659-b800-5b1b48bd0d4e@proxmox.com \
--to=f.schauer@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox