public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Alexandre Derumier <aderumier@odiso.com>
Subject: Re: [pve-devel] [PATCH pve-network] zones: simple|evpn : only enable ip-forward if gateway is defined on the subnet
Date: Mon, 10 May 2021 09:36:46 +0200	[thread overview]
Message-ID: <e6d79084-4c6b-05cf-c4c6-394fcbf22358@proxmox.com> (raw)
In-Reply-To: <20210510064058.503015-1-aderumier@odiso.com>

On 10.05.21 08:40, Alexandre Derumier wrote:
> diff --git a/test/zones/simple/ipv4v6nogateway/sdn_config b/test/zones/simple/ipv4v6nogateway/sdn_config
> new file mode 100644
> index 0000000..dbd75c9
> --- /dev/null
> +++ b/test/zones/simple/ipv4v6nogateway/sdn_config
> @@ -0,0 +1,25 @@
> +{
> +  version => 1,
> +  vnets   => {
> +               ids => {
> +                        myvnet => { type => "vnet", zone => "myzone" },
> +                      },
> +             },
> +  zones   => {
> +               ids => { myzone => { ipam => "pve", type => "simple" } },
> +             },
> +  subnets => {
> +		ids => {
> +			'myzone-192.168.0.0-24' => {
> +							'type' => 'subnet',
> +							'vnet' => 'myvnet',
> +						},
> +			'myzone-2a08:2142:302:3::-64' => {
> +							'type' => 'subnet',
> +							'vnet' => 'myvnet',
> +							}
> +		}
> +             }
> +}

In general:
can we please format this "pretty" human-readable?

Also, anything against switching that to JSON? I do not really like the eval on
file content in the test framework and the original running config is also in JSON...

I could just do that with a simple perl script like
perl -MJSON -e 'my $d=""; while(<>) {$d .= $_;} print to_json(eval $d, {pretty=>1,canonical=>1});' FILEs...
put in a bash loop.




  reply	other threads:[~2021-05-10  7:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-10  6:40 Alexandre Derumier
2021-05-10  7:36 ` Thomas Lamprecht [this message]
2021-05-10  7:38 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e6d79084-4c6b-05cf-c4c6-394fcbf22358@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=aderumier@odiso.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal