[pve-devel] applied: [PATCH storage v5] fix #957: iscsi: improve iscsi_test_portal logic

[pve-devel] applied: [PATCH storage v5] fix #957: iscsi: improve iscsi_test_portal logic

[Thomas Lamprecht]

Am 20.03.25 um 15:23 schrieb Victor Seva:
> Check if there is already a logged session present and
> fall back to previous TCP check port connection.
> 
> pvestatd is calling check_connection every 10 seconds.
> This check produces a lot of noise at the iscsi server logging.
> 
> Signed-off-by: Victor Seva <linuxmaniac@torreviejawireless.org>
> ---
> 
> changes since v4:
> 
> * rework commit message wording and subject in proper format
> 
> * iscsi_test_session():
>   use [0-9] instead of \d
>   simplify return logic checking $state is defined too
> 
> * iscsi_test_portal():
>   fallback to TCP check connection if session is not LOGGED_IN
> 
> * iscsi_discovery():
>   rename $target to $target_in to avoid variable shadowing
> 
>  src/PVE/Storage.pm             |  2 +-
>  src/PVE/Storage/ISCSIPlugin.pm | 39 ++++++++++++++++++++++++++--------
>  2 files changed, 31 insertions(+), 10 deletions(-)
> 
>

applied with Mira's and Friedrich's R-b and T-b trailers, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel